Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessor using unsuitable property #964

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Fix accessor using unsuitable property #964

merged 4 commits into from
Nov 8, 2024

Conversation

KornevNikita
Copy link
Contributor

Accessor shouldn't use buffer::property.
It looks like there is no real need for properties to contain any property, as the test just checks all possible constructors.

@KornevNikita KornevNikita requested a review from a team as a code owner October 16, 2024 09:59
@KornevNikita
Fix accessor using unsuitable property
92579dd 
Accessor shouldn't use buffer::property.
It looks like there is no real need for `properties` to contain any
property, as the test just checks all possible constructors.
@KornevNikita KornevNikita force-pushed the fix-accessor-property branch from b79457f to 92579dd Compare October 16, 2024 11:18
@KornevNikita KornevNikita reopened this Oct 17, 2024
@KornevNikita
Copy link
Contributor Author

For some reason the runner is reaching the time limit.

@KornevNikita KornevNikita reopened this Oct 21, 2024
@AlexeySachkov
Copy link
Contributor

For some reason the runner is reaching the time limit.

It seems like CI attempts to build all the CTS tests, which takes a while. Not sure why, because ccache should be in place and in general we should probably only re-build affected suites, not all of them

@KornevNikita
Copy link
Contributor Author

@bader hi, how should we proceed here?

@bader
Copy link
Contributor

bader commented Oct 29, 2024

@bader hi, how should we proceed here?

Pass CI + get approval from non-Intel implementer => merge PR.

Are you asking something else?

@KornevNikita
Copy link
Contributor Author

@bader hi, how should we proceed here?

Pass CI + get approval from non-Intel implementer => merge PR.

Are you asking something else?

Yes:) The patch can't pass CI. Looks like it builds the whole project and reaches the timelimit.

@bader
Copy link
Contributor

bader commented Oct 29, 2024

Yes:) The patch can't pass CI. Looks like it builds the whole project and reaches the timelimit.

I see at least two options to investigate:

keryell
keryell approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@KornevNikita
Copy link
Contributor Author

@bader can we treat the current pre-commit status as passed? Looks like the build was successful, the workflow just failed the "Post Set up ccache" step (I guess due to time limit?). Can we merge this?

@bader bader merged commit 8623df0 into KhronosGroup:main Nov 8, 2024
6 of 8 checks passed
@bader
Copy link
Contributor

bader commented Nov 8, 2024

I hope #982 will fix problems with ccache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KornevNikita @AlexeySachkov @bader @keryell